jquery - How refactor switch in javascript for cleaner code? -


i trying write cleaner javascript / jquery code. how refactor function cleaner , smaller. seems there better way this. works i'm sure there better way of getting writing function this. in advance!

function filterform(purpose, entry) {     switch (purpose) {         case 'business' :              switch (entry) {                 case 'single':                      $("#moreq1").css( "display", "block" );                        $("#moreq2").css( "display", "none"  );                        $("#moreq3").css( "display", "none"  );                        break;                 case 'double':                      $("#moreq1").css( "display", "block" );                        $("#moreq2").css( "display", "none"  );                        $("#moreq3").css( "display", "none"  );                        break;                 case 'multiple' :                      $("#moreq1").css( "display", "block" );                        $("#moreq2").css( "display", "block" );                        $("#moreq3").css( "display", "none"  );                        break;                 }                  break;             case 'private' :                  switch (entry) {                     case 'single'   :                          $("#moreq1").css( "display", "block" );                            $("#moreq2").css( "display", "none"  );                            $("#moreq3").css( "display", "none"  );                            break;                     case 'double'   :                          $("#moreq1").css( "display", "none"  );                            $("#moreq2").css( "display", "none"  );                            $("#moreq3").css( "display", "none"  );                            break;                     case 'multiple' :                          $("#moreq1").css( "display", "none"  );                            $("#moreq2").css( "display", "none"  );                           $("#moreq3").css( "display", "none"  );                            break;                 }                     break;             case 'tourist' :                  switch (entry) {                     case 'single'   :                          $("#moreq1").css( "display", "block" );                            $("#moreq2").css( "display", "none"  );                            $("#moreq3").css( "display", "block"  );                            break;                     case 'double'   :                          $("#moreq1").css( "display", "none" );                            $("#moreq2").css( "display", "none"  );                            $("#moreq3").css( "display", "none"  );                            break;                     case 'multiple' :                          $("#moreq1").css( "display", "none"  );                            $("#moreq2").css( "display", "none" );                            $("#moreq3").css( "display", "none" );                            break;                 }                         break;             }     } }

while other answers have done decent job of combining possibilities, seems more logical me use "map" of possibilities, , reference that:

var filterform = (function () {     var moreq = [         "",        // can use indexes starting @ 1         "moreq1",         "moreq2",         "moreq3"     ], purposes = {         "business": {             "single": [moreq[1]],             "double": [moreq[1]],             "multiple": [moreq[1], moreq[2]]         },         "private": {             "single": [moreq[1]],             "double": [],             "multiple": []         },         "tourist": {             "single": [moreq[1], moreq[],             "double": [],             "multiple": []         }     };      return function (purpose, entry) {         var i, j, cur, display;          (i = 1, j = moreq.length; < j; i++) {             cur = moreq[i];             display = purposes[purpose][entry].indexof(cur) > -1 ? "block" : "none";             console.log("setting " + cur + " " + display);             //$("#" + cur).css("display", display);         }     }; }());  filterform("business", "multiple");

demo: http://jsfiddle.net/w3jnn/1/

the arrays in object elements set display block. want change specific setting, modify purposes object's arrays.

and of course, function doesn't checking purposes[purpose][entry].indexof(cur) > -1 part - assumes purpose , entry parameters have valid values. modified check, didn't seem important right now.

as note, uses closure (the surrounding (function () { })) instantiate purposes , items variables once, yet keep them out of global scope.

also note, array.indexof method isn't supported in browsers (mainly old ie), there's shim @ https://developer.mozilla.org/en-us/docs/web/javascript/reference/global_objects/array/indexof#compatibility include on page make sure works, among other ones can find google.


Comments

Post a Comment

Popular posts from this blog

php - Calling a template part from a post -

i include iframe within post in wordpress. located inside content of post, meaning cannot in post template file, otherwise either before or after. i'd add facebook plugin within posts: <div id="socialwrap"><div class="fb-like" data-href="http://onlinearizonahomes.info" data-send="true" data-width="450" data-show-faces="true" data-font="arial"></div></div> i thinking of calling template part within post <?php get_template_part( 'social' ); ?> cannot use php within post without plugin (i'd avoid using plugin this). an alternative using javascript create html in post, seems unnecessary use of javascript. what best way add html within wordpress post? you can use shortcode. add functions.php function cudjex_fbshare( $atts, $content = null ) { global $post; $link = get_permalink($post->id); return '<div id="socialwrap...
Read more

Firefox SVG shape not printing when it has stroke -

Image
i having issue svg shapes have stroke , trying them print in firefox. this simplest example: <svg xmlns="http://www.w3.org/2000/svg" version="1.1" xmlns:xlink="http://www.w3.org/1999/xlink"> <rect x="0" y="0" rx="15" ry="15" width="300" height="400" style="stroke:black;stroke-width:5;" fill="black" /> <circle id="firstcircle" cx="50" cy="50" r="30" stroke="black" stroke-width="2" fill="white" style="opacity:0.75;"/> <circle id="secondcircle" cx="50" cy="150" r="30" fill="white" style="opacity:0.75;"/> </svg> when try , print first shape 1 of 2 things: it not show @ all it shows off center in bounding box. the second shape no stroke shows expected, expected. when displaying on scre...
Read more

How to mention the localhost in android -

i trying call localhost in android application. unfortunately not possible used several methods emulator local host http://10.0.2.2/android/dbconnection.php and network ip address http://192.168.1.xx/android/dbconnection.php also http://localhost:8080/android/dbconnection.php but nothing connected localhost. purpose refer stackoverflow answers not working i facing same problem when worked on localhost. referred stackoverflow answer got solution create new emulator works fine in new emulator.
Read more